Code review comment for lp:tomdroid/beta

@Thomas

1) THANK YOU. This will make my life a great deal easier.

You're welcome, mine too :)

2) I can't seem to edit the title of a newly-created note at all.

strange, what is your Android version?

3) When I back out of editing a note, the "Discard Changes?" dialogue has two buttons, "Cancel" and "Yes". This is really rather confusing, because discarding the note is a cancelling action, yet pressing "Cancel" cancels the cancelling.

I'm not sure about this... Stefan was the one who made the dialog, but I can see his reasoning - you are cancelling the action you have decided to perform. I'll leave it up to him/Olivier to decide on a change.

4) When I finish a sentence I'd rather like temporary shift to capitals as with other text areas. I don't know how easy this is, but I suspect it's just a flag somewhere.

Yes, that's just a flag, can do.

5) The toolbar that pops out from the top right is probably unnecessary, since formatting in Tomboy notes is done inline.

I don't understand what you mean; how can you format notes without the toolbar?

6) Also, once the toolbar's been popped out, it can't be put back again. This is a nuisance, since it obscures the title.

Pressing the button again closes it for me...

7) I would prefer notes to be editable the moment you open them, rather than having to press a button (as it was in Conboy for Maemo, and as it is in Tomboy.)

Good point, worth discussing.

8) The "save" option is really rather hard to find, buried in the actions menu.

This is by design, since the notes DO save automatically on pause. Tomboy has no save button, for this reason.

9) Saving should be automatic as you type anyway, as in Conboy and Tomboy, rather than something you have to ask for. But if you don't do this, you should also have the option on the "discard changes?" dialogue of "no, save them".

As said, save IS automatic, but only on pause; to save on every keypress is probably not feasible for a mobile platform. Not sure, though.