Tomdroid

Code review comment for lp:tomdroid/beta

note-editing-and-syncing
Merge into main

Revision history for this message

NoahY (noahy) wrote on 2012-07-23:

@Lucas - sorry about that... during testing, save frequently! I tried catching the onTextChanged, but somehow putting the text into the buffer actually changes the text itself. I'm not sure we want to save after every edit, since reverting changes is not as easy as on a computer. On the other hand, I don't think that's my call, and I'll leave it up to the maintainers to decide how and when to save. Anyway, the onPause() problem was that I was accidentally retrieving the note from the database onResume(). Should be fixed now.

@Stefan - thanks for catching that, I'm glad to see the maintainers taking interest! The grey thing was me trying to keep the selected item highlighted... and failing. I've reverted my changes, should be back to default now... still can't get it to show which note is being viewed in the two-pane mode.

As for the new note empty title thing, I didn't really see it as a problem, but I know Tomboy has default values (via a template, I guess?). Sure, it would be an option to wait to save the note until you actually hit the save button... in this case, I just followed Tomboy's behaviour, since it is relatively easy to delete notes now. But it can be done either way.

@Mads - I like the idea of saving on back button... on the other hand, how then would you cancel changes? I know that is Tomboy's behaviour, so we can go with that... also of course on sync we can revert. I guess then the "Save" button becomes irrelevent, though? For now, I will add a preference to just have it save at every onPause(), which is everytime the activity loses focus (onDestroy() doesn't work properly for back button), and remove the "Save" button if it the pref is set.

As for links, I removed something I shouldn't have from the manifest, sorry... back now.

Reinstalling - that is to be expected, since it's just a debug apk.

The app doesn't sync at startup... you have to go to the menu > Sync. I'll leave it up to the maintainers to decide whether to leave it like that or as Stefan suggests, import the action bar for <11. Right now, on 11+, it shows the actionbar with menu buttons. I'm not sure what is the pure black you are seeing at the top... maybe you can give a screenshot?

Shortcuts - this was the same problem as the links, should be fixed in latest commit.

@Lucas - sorry about that... during testing, save frequently!  I tried catching the onTextChanged, but somehow putting the text into the buffer actually changes the text itself.  I'm not sure we want to save after every edit, since reverting changes is not as easy as on a computer.  On the other hand, I don't think that's my call, and I'll leave it up to the maintainers to decide how and when to save.  Anyway, the onPause() problem was that I was accidentally retrieving the note from the database onResume().  Should be fixed now.

@Stefan - thanks for catching that, I'm glad to see the maintainers taking interest!  The grey thing was me trying to keep the selected item highlighted... and failing.  I've reverted my changes, should be back to default now... still can't get it to show which note is being viewed in the two-pane mode.

As for the new note empty title thing, I didn't really see it as a problem, but I know Tomboy has default values (via a template, I guess?).  Sure, it would be an option to wait to save the note until you actually hit the save button... in this case, I just followed Tomboy's behaviour, since it is relatively easy to delete notes now.  But it can be done either way.

@Mads - I like the idea of saving on back button... on the other hand, how then would you cancel changes?  I know that is Tomboy's behaviour, so we can go with that... also of course on sync we can revert.  I guess then the "Save" button becomes irrelevent, though?  For now, I will add a preference to just have it save at every onPause(), which is everytime the activity loses focus (onDestroy() doesn't work properly for back button), and remove the "Save" button if it the pref is set.

As for links, I removed something I shouldn't have from the manifest, sorry... back now.

Reinstalling - that is to be expected, since it's just a debug apk.

The app doesn't sync at startup... you have to go to the menu > Sync.  I'll leave it up to the maintainers to decide whether to leave it like that or as Stefan suggests, import the action bar for <11.  Right now, on 11+, it shows the actionbar with menu buttons.  I'm not sure what is the pure black you are seeing at the top... maybe you can give a screenshot?

Shortcuts - this was the same problem as the links, should be fixed in latest commit.

« Back to merge proposal