Code review comment for lp:~tomdroid-dev/tomdroid/two-way-sync

Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

I think, if we get this awesome editing feature into the next release, we should do some minor changes to significantly enhance usability.

In list view it would be easy to implement and really awesome to have
 * Longpress -> Delete
 * Longpress -> Edit

In "Note view" and "Edit view" I would remove the Menu -> Settings Button, because the settings do not affect viewing Notes or editing them, therefore the button is just confusing. Atm, the settings screen is just for synchronisation. So I would just display it in the List view.

Also displaying the Sync Button, while displaying/editing a note is not user-friendly, because the note won't update itself while in "Note view" or "Edit view". You have to go back to the list and "reload" the note. Alternatively one could refresh the note after synchronising.

In note view we could add a menu button "List View" to get back to the List immediately. Now if you press several internal links, the back button is not really convenient.

I would also recommend to cut away the <note-content version="0.1"> tag at the beginning and the end. this is easily done and makes the note much more readable while editing.
Additionally it would be awesome to have a separate text field for the title, as it is on Ubuntu One online. I think this is also easily done, by just cutting the string at the first line break.

I hope my suggested optimisations are not too much effort, but for me it sounds, as one who knows the code just has to add/delete a view lines.

Jango

« Back to merge proposal