Code review comment for lp:~tomdroid-dev/tomdroid/sync-ui

Revision history for this message
Benoit Garret (benoit.garret) wrote :

It's also my fault the merge hasn't been done before, I haven't followed through with Rodja, mainly due to a lack of time on my part.

1) No new commits have been done on the web-sync branch, so the sync-ui supersedes it. This merge request is the right one.

2) commons-codec is needed by signpost. I pulled everything because it was easier, but I believe only a small set of its functionality is needed. We could rip out the parts that interest us and cut down a lot on the size.

3) When I began working with signpost, a few bugs prevented it from working with snowy and ubuntu one, that's why I kept a patched copy. It's just a matter of looking if there's been a release with the fixes I submitted upstream.

4) As far as I know, only Rodja and I worked on this. I suggest we both go through the files and put the notices on the files we know we created.

« Back to merge proposal