Code review comment for lp:~tomdroid-dev/tomdroid/search-interface
Revision history for this message
| Olivier Bilodeau (plaxx) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Started the review.
One minor thing I note is that you need to be more careful about consistency. For ex: in the new search strings there is search_hint (underscore separation), strNoResults (java-style object name) and SearchResultTitle (java-style class name). We should aim for only one notation style unless we have a pattern.
Really not a big problem, not enough to go back and fix it IMO but with new code/strings we should aim to avoid it.