Merge lp:~tomasgroth/openlp/packaging-win-ver-fix into lp:openlp/packaging

Proposed by Tomas Groth
Status: Merged
Merged at revision: 44
Proposed branch: lp:~tomasgroth/openlp/packaging-win-ver-fix
Merge into: lp:openlp/packaging
Diff against target: 55 lines (+6/-3)
3 files modified
builders/windows-builder.py (+1/-1)
windows/OpenLP.iss.default (+2/-1)
windows/appinfo.ini.default (+3/-1)
To merge this branch: bzr merge lp:~tomasgroth/openlp/packaging-win-ver-fix
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Raoul Snyman Approve
Review via email: mp+364402@code.launchpad.net

Commit message

Fix some issues in windows packaging related to portable setup.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'builders/windows-builder.py'
--- builders/windows-builder.py 2019-03-08 21:20:20 +0000
+++ builders/windows-builder.py 2019-03-13 21:01:59 +0000
@@ -216,7 +216,7 @@
216 self._print_verbose('... Building PortableApps Installer')216 self._print_verbose('... Building PortableApps Installer')
217 self._run_command([self.portableinstaller_exe, self.portable_dest_path],217 self._run_command([self.portableinstaller_exe, self.portable_dest_path],
218 'Error running PortableApps Installer')218 'Error running PortableApps Installer')
219 portable_exe_name = 'OpenLPPortable_%s.paf.exe' % self.portable_version219 portable_exe_name = 'OpenLPPortable_{ver}-{arch}.paf.exe'.format(ver=self.portable_version, arch=self.arch)
220 portable_exe_path = os.path.abspath(os.path.join(self.portable_dest_path, '..', portable_exe_name))220 portable_exe_path = os.path.abspath(os.path.join(self.portable_dest_path, '..', portable_exe_name))
221 self._print_verbose('... Portable Build: {}'.format(portable_exe_path))221 self._print_verbose('... Portable Build: {}'.format(portable_exe_path))
222 if os.path.exists(portable_exe_path):222 if os.path.exists(portable_exe_path):
223223
=== modified file 'windows/OpenLP.iss.default'
--- windows/OpenLP.iss.default 2019-03-08 21:20:20 +0000
+++ windows/OpenLP.iss.default 2019-03-13 21:01:59 +0000
@@ -7,7 +7,7 @@
7#define AppPublisher "OpenLP Developers"7#define AppPublisher "OpenLP Developers"
8#define AppURL "http://openlp.org/"8#define AppURL "http://openlp.org/"
9#define AppExeName "OpenLP.exe"9#define AppExeName "OpenLP.exe"
10#define Arch "%(arch)"10#define Arch "%(arch)s"
1111
12#define FileHandle FileOpen("%(branch)s\dist\OpenLP\.version")12#define FileHandle FileOpen("%(branch)s\dist\OpenLP\.version")
13#define FileLine FileRead(FileHandle)13#define FileLine FileRead(FileHandle)
@@ -87,6 +87,7 @@
8787
88[Registry]88[Registry]
89Root: HKCR; Subkey: .osz; ValueType: string; ValueName: ; ValueData: OpenLP; Flags: uninsdeletevalue89Root: HKCR; Subkey: .osz; ValueType: string; ValueName: ; ValueData: OpenLP; Flags: uninsdeletevalue
90Root: HKCR; Subkey: .oszl; ValueType: string; ValueName: ; ValueData: OpenLP; Flags: uninsdeletevalue
90Root: HKCR; Subkey: OpenLP; ValueType: string; ValueName: ; ValueData: OpenLP Service; Flags: uninsdeletekey91Root: HKCR; Subkey: OpenLP; ValueType: string; ValueName: ; ValueData: OpenLP Service; Flags: uninsdeletekey
91Root: HKCR; Subkey: OpenLP\DefaultIcon; ValueType: string; ValueName: ; ValueData: {app}\OpenLP.exe,092Root: HKCR; Subkey: OpenLP\DefaultIcon; ValueType: string; ValueName: ; ValueData: {app}\OpenLP.exe,0
92Root: HKCR; Subkey: OpenLP\shell\open\command; ValueType: string; ValueName: ; ValueData: """{app}\OpenLP.exe"" ""%1"""93Root: HKCR; Subkey: OpenLP\shell\open\command; ValueType: string; ValueName: ; ValueData: """{app}\OpenLP.exe"" ""%1"""
9394
=== modified file 'windows/appinfo.ini.default'
--- windows/appinfo.ini.default 2019-03-08 21:20:20 +0000
+++ windows/appinfo.ini.default 2019-03-13 21:01:59 +0000
@@ -19,7 +19,7 @@
1919
20[Version]20[Version]
21DisplayVersion=%(display_version)s-%(arch)s21DisplayVersion=%(display_version)s-%(arch)s
22PackageVersion=%(package_version)s-%(arch)s22PackageVersion=%(package_version)s
2323
24[Control]24[Control]
25Icons=125Icons=1
@@ -27,6 +27,8 @@
2727
28[Associations]28[Associations]
29FileType=osz29FileType=osz
30FileType=oszl
3031
31[FileTypeIcons]32[FileTypeIcons]
32osz=app33osz=app
34oszl=app

Subscribers

People subscribed via source and target branches