Code review comment for lp:~tom-gall/linaro-seeds/fix752843-linaro.natty
Revision history for this message
| Steve Langasek (vorlon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I don't understand the choices that are made here for slimming down the 'required' package set.
- grep, gzip, hostname, mount, and passwd are dropped. With the exception of 'passwd', these are Essential: yes packages, meaning they may be used by any Ubuntu package without declaring a dependency. How was the determination made to cut these packages (and not others)?
- if we were enabling busybox instead, then it would make sense to drop most of these, and others besides (e.g., coreutils), but I don't see busybox added anywhere. Should it be?
- * isc-dhcp-client # LaMontJones
Why remove isc-dhcp-client but not the rest of the network stack? (or at least netcat and ntpdate, I would think?) Is it useful to have ifupdown on here without dhcp-client?
+ * mountall #needed by upstart
+ * initscripts #needed by upstart
I don't think it should be necessary to seed these separately then; doesn't upstart pull them in automatically as dependencies?