Merge lp:~tobias-klevenz/terminator/fix-transparent-seprators into lp:terminator

Proposed by Tobias Klevenz on 2018-02-11
Status: Needs review
Proposed branch: lp:~tobias-klevenz/terminator/fix-transparent-seprators
Merge into: lp:terminator
Diff against target: 27 lines (+8/-2)
1 file modified
terminatorlib/terminator.py (+8/-2)
To merge this branch: bzr merge lp:~tobias-klevenz/terminator/fix-transparent-seprators
Reviewer Review Type Date Requested Status
Bryce Harrington 2018-02-11 Needs Fixing on 2019-07-25
Review via email: mp+337512@code.launchpad.net

Description of the change

Found an issue with various newer Gtk3 themes on Ubuntu 17.10 where terminators pane separators appeared completely transparent.

Affected themes:
https://github.com/pop-os/gtk-theme
https://github.com/nana-4/materia-theme

Additionally the handle_size set in the config was ignored for all themes, using min-width and min-height on paned separator fixed this.

To post a comment you must log in.
Bryce Harrington (bryce) wrote :

Being able to resize the separator width again is a nice improvement, and works well.

This does fix the transparency issue, although on my system I noticed this added a stipple pattern to the separator background, which seems to create drawing glitches with its black border. Turning off the border seems to give more pleasant results with this fix:

            .terminator-terminal-window paned separator {
                background-color: @theme_bg_color;
                border-width: 0; }

Maybe there's a better way to address this, but with that fixed one way or another, +1 approve.

Test case I used:

$ cat > /tmp/config <<EOF
[layouts]
  [[test]]
    [[[window0]]]
      parent = ""
      type = Window
    [[[child0]]]
      parent = window0
      type = HPaned
    [[[child1]]]
      parent = child0
      type = Terminal
    [[[child2]]]
      parent = child0
      type = Terminal
EOF

$ terminator --no-dbus --config /tmp/config --layout test

review: Needs Fixing

Unmerged revisions

1788. By Tobias Klevenz on 2018-02-11

fix transparent pane separator for newer Gtk3 themes like Materia and Pop

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'terminatorlib/terminator.py'
2--- terminatorlib/terminator.py 2017-02-28 19:48:11 +0000
3+++ terminatorlib/terminator.py 2018-02-11 13:02:18 +0000
4@@ -454,6 +454,9 @@
5 .terminator-terminal-window .pane-separator {
6 background-color: @theme_bg_color; }
7
8+ .terminator-terminal-window paned separator {
9+ background-color: @theme_bg_color; }
10+
11 .terminator-terminal-window .terminator-terminal-searchbar {
12 background-color: @theme_bg_color; }
13 """
14@@ -541,8 +544,11 @@
15 css += """
16 .terminator-terminal-window GtkPaned,
17 .terminator-terminal-window paned {
18- -GtkPaned-handle-size: %s; }
19- """ % self.config['handle_size']
20+ -GtkPaned-handle-size: %(size)s; }
21+ .terminator-terminal-window paned > separator {
22+ min-width: %(size)spx;
23+ min-height: %(size)spx; }
24+ """ % {"size":self.config['handle_size']}
25 style_provider = Gtk.CssProvider()
26 style_provider.load_from_data(css)
27 self.style_providers.append(style_provider)

Subscribers

People subscribed via source and target branches

to status/vote changes: