Merge lp:~tobias-klevenz/terminator/fix-transparent-seprators into lp:terminator/gtk3

[Tobias Klevenz]

Found an issue with various newer Gtk3 themes on Ubuntu 17.10 where terminators pane separators appeared completely transparent.

Affected themes:
https://github.com/pop-os/gtk-theme
https://github.com/nana-4/materia-theme

Additionally the handle_size set in the config was ignored for all themes, using min-width and min-height on paned separator fixed this.

[Bryce Harrington (bryce)]

Being able to resize the separator width again is a nice improvement, and works well.

This does fix the transparency issue, although on my system I noticed this added a stipple pattern to the separator background, which seems to create drawing glitches with its black border. Turning off the border seems to give more pleasant results with this fix:

            .terminator-terminal-window paned separator {
                background-color: @theme_bg_color;
                border-width: 0; }

Maybe there's a better way to address this, but with that fixed one way or another, +1 approve.

Test case I used:

$ cat > /tmp/config <<EOF
[layouts]
  [[test]]
    [[[window0]]]
      parent = ""
      type = Window
    [[[child0]]]
      parent = window0
      type = HPaned
    [[[child1]]]
      parent = child0
      type = Terminal
    [[[child2]]]
      parent = child0
      type = Terminal
EOF

$ terminator --no-dbus --config /tmp/config --layout test

review: Needs Fixing

Unmerged revisions

1788. By Tobias Klevenz on 2018-02-11

fix transparent pane separator for newer Gtk3 themes like Materia and Pop

=== modified file 'terminatorlib/terminator.py'
--- terminatorlib/terminator.py	2017-02-28 19:48:11 +0000
+++ terminatorlib/terminator.py	2018-02-11 13:02:18 +0000
@@ -454,6 +454,9 @@
             .terminator-terminal-window .pane-separator {
                 background-color: @theme_bg_color; }
 
+            .terminator-terminal-window paned separator {
+                background-color: @theme_bg_color; }
+
             .terminator-terminal-window .terminator-terminal-searchbar {
                 background-color: @theme_bg_color; }
             """
@@ -541,8 +544,11 @@
             css += """
                 .terminator-terminal-window GtkPaned,
                 .terminator-terminal-window paned {
-                    -GtkPaned-handle-size: %s; }
-                """ % self.config['handle_size']
+                    -GtkPaned-handle-size: %(size)s; }
+                .terminator-terminal-window paned > separator {
+                    min-width: %(size)spx;
+                    min-height: %(size)spx; }
+                """ % {"size":self.config['handle_size']}
         style_provider = Gtk.CssProvider()
         style_provider.load_from_data(css)
         self.style_providers.append(style_provider)