Code review comment for lp:~tobias-klevenz/terminator/fix-transparent-seprators

Revision history for this message
Bryce Harrington (bryce) wrote :

Being able to resize the separator width again is a nice improvement, and works well.

This does fix the transparency issue, although on my system I noticed this added a stipple pattern to the separator background, which seems to create drawing glitches with its black border. Turning off the border seems to give more pleasant results with this fix:

            .terminator-terminal-window paned separator {
                background-color: @theme_bg_color;
                border-width: 0; }

Maybe there's a better way to address this, but with that fixed one way or another, +1 approve.

Test case I used:

$ cat > /tmp/config <<EOF
[layouts]
  [[test]]
    [[[window0]]]
      parent = ""
      type = Window
    [[[child0]]]
      parent = window0
      type = HPaned
    [[[child1]]]
      parent = child0
      type = Terminal
    [[[child2]]]
      parent = child0
      type = Terminal
EOF

$ terminator --no-dbus --config /tmp/config --layout test

review: Needs Fixing

« Back to merge proposal