Code review comment for ~toabctl/ubuntu-docker-images/+git/utils:tag-filter

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Thomas.

I like the idea of filtering tags; this is something I've been meaning to implement for a while TBH. I understand that this only works for Ubuntu base images for now, but hey, baby steps.

I'm leaving a comment about a discrepancy between how you declare the TAG_FILTER variable and how you use it (array vs. normal variable). With that fixed, I can merge the MP.

Thanks again.

review: Needs Fixing

« Back to merge proposal