Code review comment for lp:~tjoneslo/akiban-server/json-entity-name-collision-resolution

Revision history for this message
Nathan Williams (nwilliams) wrote :

Looks pretty good.

I think we can skip the "is same schema" logic. That was really working around the collapsed namespace issue, which this branch does explicitly.

Since they must be unused, can you delete the commented out members on UserTable?

review: Needs Fixing

« Back to merge proposal