Code review comment for lp:~tjoneslo/akiban-server/add-rest-model-hash
Revision history for this message
| Nathan Williams (nwilliams) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Sorry to be picky, and maybe this is premature optimization, but the new code is pretty wasteful. Construct a BigInteger, toString() on that, maybe construct another sting with leading zero, and append that into a StringBuilder, toString() on that, and then toUppper or toLower it. That's six lines and a lot of intermediate steps. The previous, simple loop was five and avoided it all.
Feel free to push back.