Code review comment for lp:~tjoneslo/akiban-server/add-rest-model-hash

Revision history for this message
Thomas Jones-Low (tjoneslo) wrote :

Updated the md5 generation (was building based on the UTF-16 java characters, now using UTF-8 as expected.

echo -n "This is a test string" |md5sum
c639efc1e98762233743a75e7798dd9c -

It now also matches the results produced by MySQL, Python, and two online MD5 hash generators.

Updated the MessageDigestWriter to use getFormatMD5 for the string value.

Refactor the formatMD5() into the Strings class. Also update the MD5 function to use the same.

review: Needs Resubmitting

« Back to merge proposal