Code review comment for lp:~tjoneslo/akiban-server/add-rest-model-hash

Revision history for this message
Nathan Williams (nwilliams) wrote :

Looks like something is slightly off with our computation. Perhaps it's the incremental digest updating (random guess)?

$ echo "This is a test string" |md5sum
b584c39f97dfe71ebceea3fdb860ed6c -

The digestResult variable and toString() behavior is a little funny. Seems like always printing the digest would be useful (toString being for debug, etc).

There is also a helper in SecurityService for formatting an md5 byte array. Perhaps slicing that out into util.Strings or such would be good.

review: Needs Fixing

« Back to merge proposal