Merge lp:~tintou/switchboard/small-fixes into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Corentin Noël
Status: Merged
Approved by: Danielle Foré
Approved revision: 592
Merged at revision: 592
Proposed branch: lp:~tintou/switchboard/small-fixes
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 28 lines (+4/-6)
1 file modified
src/CategoryView.vala (+4/-6)
To merge this branch: bzr merge lp:~tintou/switchboard/small-fixes
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+282504@code.launchpad.net

Commit message

Fix Layout for RTL and disable markup on category label as it's no longer needed

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/CategoryView.vala'
--- src/CategoryView.vala 2016-01-07 23:29:20 +0000
+++ src/CategoryView.vala 2016-01-13 20:07:40 +0000
@@ -57,21 +57,19 @@
57 private void setup_category (Switchboard.Plug.Category category, int i) {57 private void setup_category (Switchboard.Plug.Category category, int i) {
58 var category_label = new Gtk.Label (get_category_name (category));58 var category_label = new Gtk.Label (get_category_name (category));
59 category_label.get_style_context ().add_class ("category-label");59 category_label.get_style_context ().add_class ("category-label");
6060 category_label.halign = Gtk.Align.START;
61 category_label.margin_left = 12;
62 category_label.margin_right = 8;
63 ((Gtk.Misc) category_label).xalign = 0.02f;
64 category_label.use_markup = true;
6561
66 var category_plugs = setup_icon_view ();62 var category_plugs = setup_icon_view ();
67 category_plugs.get_style_context ().remove_class (Gtk.STYLE_CLASS_VIEW);63 category_plugs.get_style_context ().remove_class (Gtk.STYLE_CLASS_VIEW);
6864
69 var grid = new Gtk.Grid ();65 var grid = new Gtk.Grid ();
66 grid.margin_start = 12;
67 grid.margin_end = 12;
68 grid.column_spacing = 6;
7069
71 // Always add a Seperator70 // Always add a Seperator
72 var h_separator = new Gtk.Separator (Gtk.Orientation.HORIZONTAL);71 var h_separator = new Gtk.Separator (Gtk.Orientation.HORIZONTAL);
73 h_separator.set_hexpand (true);72 h_separator.set_hexpand (true);
74 h_separator.margin_right = 12;
75 grid.attach (category_label, 0, 0, 1, 1);73 grid.attach (category_label, 0, 0, 1, 1);
76 grid.attach (h_separator, 1, 0, 1, 1);74 grid.attach (h_separator, 1, 0, 1, 1);
7775

Subscribers

People subscribed via source and target branches

to all changes: