Merge lp:~timo-jyrinki/ubuntu-ui-toolkit/ucstylehints_qt55 into lp:ubuntu-ui-toolkit/staging

Proposed by Timo Jyrinki
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1561
Merged at revision: 1561
Proposed branch: lp:~timo-jyrinki/ubuntu-ui-toolkit/ucstylehints_qt55
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 25 lines (+11/-4)
1 file modified
modules/Ubuntu/Components/plugin/ucstylehints.cpp (+11/-4)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-ui-toolkit/ucstylehints_qt55
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+264517@code.launchpad.net

Commit message

Fix ucstylehints.cpp compilation with Qt 5.5

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Small fix and we're good.

review: Needs Fixing
1560. By Timo Jyrinki

Address review comments.

Revision history for this message
Zsombor Egri (zsombi) wrote :

Still needs more love :)

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1561. By Timo Jyrinki

Address review comments ^2

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

That's my boy ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/Ubuntu/Components/plugin/ucstylehints.cpp'
--- modules/Ubuntu/Components/plugin/ucstylehints.cpp 2015-06-02 15:21:00 +0000
+++ modules/Ubuntu/Components/plugin/ucstylehints.cpp 2015-07-13 15:02:09 +0000
@@ -100,10 +100,17 @@
100 int column = -1;100 int column = -1;
101101
102 QQmlData *ddata = QQmlData::get(this);102 QQmlData *ddata = QQmlData::get(this);
103 if (ddata && ddata->outerContext && !ddata->outerContext->url.isEmpty()) {103 if (ddata && ddata->outerContext) {
104 url = ddata->outerContext->url;104#if QT_VERSION >= QT_VERSION_CHECK(5, 5, 0)
105 line = ddata->lineNumber;105 QUrl outerContextUrl(ddata->outerContext->url());
106 column = ddata->columnNumber;106#else
107 QUrl outerContextUrl(ddata->outerContext->url);
108#endif
109 if (!outerContextUrl.isEmpty()) {
110 url = outerContextUrl;
111 line = ddata->lineNumber;
112 column = ddata->columnNumber;
113 }
107 }114 }
108 m_expressions << Expression(propertyName, binding->value.compiledScriptIndex, expression, url, line, column);115 m_expressions << Expression(propertyName, binding->value.compiledScriptIndex, expression, url, line, column);
109 break;116 break;

Subscribers

People subscribed via source and target branches