Merge lp:~timo-jyrinki/ubuntu-system-settings/enable_multiarch into lp:ubuntu-system-settings

Proposed by Timo Jyrinki
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 229
Merged at revision: 229
Proposed branch: lp:~timo-jyrinki/ubuntu-system-settings/enable_multiarch
Merge into: lp:ubuntu-system-settings
Diff against target: 39 lines (+7/-3)
1 file modified
debian/control (+7/-3)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-system-settings/enable_multiarch
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+178504@code.launchpad.net

Commit message

Enable Multi-Arch for the libraries (LP: #1208347)

Also change back to arch 'any' instead of listing archs.

Description of the change

Enable Multi-Arch for the libraries (LP: #1208347)

Also change back to arch 'any' instead of listing archs.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work, shouldn't the package have pre-depends on dpkg > multiarched-version though? Also the package doesn't really support multiarch, we didn't multiarch it but changed the paths in use to be more standard...

Revision history for this message
Sebastien Bacher (seb128) :
review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

(I meant "Pre-Depends: ${misc:Pre-Depends}" for the pre-depends of course)

229. By Timo Jyrinki

Add Pre-Depends dpkg (>= 1.15.6~), ${misc:Pre-Depends} for the multi-arch packages.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok. If enabling multi-arch still does no harm, added the Pre-Depends as well now.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks good to me, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-08-01 15:29:45 +0000
+++ debian/control 2013-08-05 08:03:24 +0000
@@ -23,7 +23,7 @@
23Vcs-Bzr: https://code.launchpad.net/~system-settings-touch/ubuntu-system-settings/trunk23Vcs-Bzr: https://code.launchpad.net/~system-settings-touch/ubuntu-system-settings/trunk
2424
25Package: ubuntu-system-settings25Package: ubuntu-system-settings
26Architecture: i386 amd64 armhf26Architecture: any
27Depends: ${misc:Depends},27Depends: ${misc:Depends},
28 ${shlibs:Depends},28 ${shlibs:Depends},
29 accountsservice,29 accountsservice,
@@ -46,9 +46,11 @@
4646
47Package: libsystemsettings147Package: libsystemsettings1
48Section: libs48Section: libs
49Architecture: i386 amd64 armhf49Architecture: any
50Multi-Arch: same
50Depends: ${misc:Depends},51Depends: ${misc:Depends},
51 ${shlibs:Depends},52 ${shlibs:Depends},
53Pre-Depends: dpkg (>= 1.15.6~), ${misc:Pre-Depends}
52Description: System Settings Library for Ubuntu Touch54Description: System Settings Library for Ubuntu Touch
53 This package contains the System Settings application used on the 55 This package contains the System Settings application used on the
54 Ubuntu Touch images, it's designed for phones, tablets and convergent 56 Ubuntu Touch images, it's designed for phones, tablets and convergent
@@ -56,10 +58,12 @@
5658
57Package: libsystemsettings-dev59Package: libsystemsettings-dev
58Section: libdevel60Section: libdevel
59Architecture: i386 amd64 armhf61Architecture: any
62Multi-Arch: same
60Depends: ${misc:Depends},63Depends: ${misc:Depends},
61 ${shlibs:Depends},64 ${shlibs:Depends},
62 libsystemsettings1 (= ${binary:Version}),65 libsystemsettings1 (= ${binary:Version}),
66Pre-Depends: dpkg (>= 1.15.6~), ${misc:Pre-Depends}
63Description: System Settings for Ubuntu Touch - development files67Description: System Settings for Ubuntu Touch - development files
64 This package contains the System Settings application used on the 68 This package contains the System Settings application used on the
65 Ubuntu Touch images, it's designed for phones, tablets and convergent 69 Ubuntu Touch images, it's designed for phones, tablets and convergent

Subscribers

People subscribed via source and target branches