Merge lp:~timo-jyrinki/libusermetrics/dont-share-dbus-sessionbus-connections into lp:libusermetrics

Proposed by Timo Jyrinki
Status: Rejected
Rejected by: Timo Jyrinki
Proposed branch: lp:~timo-jyrinki/libusermetrics/dont-share-dbus-sessionbus-connections
Merge into: lp:libusermetrics
Diff against target: 40 lines (+6/-3)
3 files modified
src/usermetricsservice/DBusDataSet.cpp (+2/-1)
src/usermetricsservice/DBusDataSource.cpp (+2/-1)
src/usermetricsservice/DBusUserData.cpp (+2/-1)
To merge this branch: bzr merge lp:~timo-jyrinki/libusermetrics/dont-share-dbus-sessionbus-connections
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+257505@code.launchpad.net

Commit message

Stop using shared DBus connections

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Unmerged revisions

193. By Timo Jyrinki

Stop using shared DBus connections also for session bus

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/usermetricsservice/DBusDataSet.cpp'
--- src/usermetricsservice/DBusDataSet.cpp 2013-10-22 08:53:23 +0000
+++ src/usermetricsservice/DBusDataSet.cpp 2015-04-27 11:46:50 +0000
@@ -49,7 +49,8 @@
49}49}
5050
51DBusDataSet::~DBusDataSet() {51DBusDataSet::~DBusDataSet() {
52 QDBusConnection connection(QDBusConnection::sessionBus());52 QDBusConnection connection(QDBusConnection::connectToBus(
53 QDBusConnection::SessionBus, "usermetrics-sessionbus_1"));
53 connection.unregisterObject(m_path);54 connection.unregisterObject(m_path);
54}55}
5556
5657
=== modified file 'src/usermetricsservice/DBusDataSource.cpp'
--- src/usermetricsservice/DBusDataSource.cpp 2015-01-29 12:37:39 +0000
+++ src/usermetricsservice/DBusDataSource.cpp 2015-04-27 11:46:50 +0000
@@ -44,7 +44,8 @@
44}44}
4545
46DBusDataSource::~DBusDataSource() {46DBusDataSource::~DBusDataSource() {
47 QDBusConnection connection(QDBusConnection::sessionBus());47 QDBusConnection connection(QDBusConnection::connectToBus(
48 QDBusConnection::SessionBus, "usermetrics-sessionbus_2"));
48 connection.unregisterObject(m_path);49 connection.unregisterObject(m_path);
49}50}
5051
5152
=== modified file 'src/usermetricsservice/DBusUserData.cpp'
--- src/usermetricsservice/DBusUserData.cpp 2014-01-20 10:33:36 +0000
+++ src/usermetricsservice/DBusUserData.cpp 2015-04-27 11:46:50 +0000
@@ -56,7 +56,8 @@
56}56}
5757
58DBusUserData::~DBusUserData() {58DBusUserData::~DBusUserData() {
59 QDBusConnection connection(QDBusConnection::sessionBus());59 QDBusConnection connection(QDBusConnection::connectToBus(
60 QDBusConnection::SessionBus, "usermetrics-sessionbus_3"));
60 connection.unregisterObject(m_path);61 connection.unregisterObject(m_path);
61}62}
6263

Subscribers

People subscribed via source and target branches

to all changes: