Code review comment for lp:~timo-jyrinki/libcolumbus/workaround_lp_1187771

That file is the only place that checks for it because one warning is all that we need. As evidenced here.

I have no idea where the NDEBUG comes from. Quick observation shows that build flags come from two different sources because optimization is defined twice:

[snip] /usr/bin/c++ [snip] -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -Wall -pedantic -Wextra -fvisibility=hidden -std=c++11 -O2 -g -DNDEBUG -fPIC

The first bunch comes from dpkg-buildflags. The latter from somewhere. I have no idea where. The only option I can think of is that they come from -DCMAKE_BUILD_TYPE=relwithdebinfo, but according to the log, that flag is not given to CMake. Has dh_auto_configure been changed to pass that in?