Merge lp:~timo-jyrinki/cupstream2distro/more_vivid into lp:cupstream2distro

Proposed by Timo Jyrinki
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 790
Merged at revision: 790
Proposed branch: lp:~timo-jyrinki/cupstream2distro/more_vivid
Merge into: lp:cupstream2distro
Diff against target: 91 lines (+10/-10)
4 files modified
citrain/jenkins-templates/upgrade-chroot.xml.tmpl (+1/-1)
citrain/prepare_silo.py (+1/-1)
tests/data/landing-123/config (+1/-1)
tests/unit/test_silomanager.py (+7/-7)
To merge this branch: bzr merge lp:~timo-jyrinki/cupstream2distro/more_vivid
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+239721@code.launchpad.net

Commit message

Add more vivid support, make vivid the default in some places.

Description of the change

This MP motivated by the error at https://ci-train.ubuntu.com/job/ubuntu-landing-004-1-build/84/console although I realize this may not be the (full) fix for that.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:790
http://jenkins.qa.ubuntu.com/job/cu2d-choo-choo-ci/239/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/cu2d-choo-choo-ci/239/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

lgtm, let's get this in production and see what happens.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'citrain/jenkins-templates/upgrade-chroot.xml.tmpl'
2--- citrain/jenkins-templates/upgrade-chroot.xml.tmpl 2014-09-28 06:07:48 +0000
3+++ citrain/jenkins-templates/upgrade-chroot.xml.tmpl 2014-10-27 13:11:08 +0000
4@@ -9,7 +9,7 @@
5 <hudson.model.StringParameterDefinition>
6 <name>distributions</name>
7 <description>These must correspond to the available set of cowbuilder chroots.</description>
8- <defaultValue>trusty utopic</defaultValue>
9+ <defaultValue>trusty utopic vivid</defaultValue>
10 </hudson.model.StringParameterDefinition>
11 </parameterDefinitions>
12 </hudson.model.ParametersDefinitionProperty>
13
14=== modified file 'citrain/prepare_silo.py'
15--- citrain/prepare_silo.py 2014-10-23 19:30:05 +0000
16+++ citrain/prepare_silo.py 2014-10-27 13:11:08 +0000
17@@ -232,7 +232,7 @@
18 source_distro,
19 source_landing))
20 source_series = (
21- "utopic" if env.DISTRIBUTION == "ubuntu-rtm" else
22+ "vivid" if env.DISTRIBUTION == "ubuntu-rtm" else
23 "14.09")
24
25 logging.info(
26
27=== modified file 'tests/data/landing-123/config'
28--- tests/data/landing-123/config 2014-09-25 01:16:41 +0000
29+++ tests/data/landing-123/config 2014-10-27 13:11:08 +0000
30@@ -2,7 +2,7 @@
31 "global": {
32 "dest": "https://api.launchpad.net/devel/ubuntu/+archive/primary",
33 "ppa": "https://api.launchpad.net/devel/~ci-train-ppa-service/+archive/ubuntu/landing-123",
34- "series": "https://api.launchpad.net/devel/ubuntu/utopic",
35+ "series": "https://api.launchpad.net/devel/ubuntu/vivid",
36 "status": {
37 "message": "Packages built",
38 "ping": true,
39
40=== modified file 'tests/unit/test_silomanager.py'
41--- tests/unit/test_silomanager.py 2014-10-13 12:27:17 +0000
42+++ tests/unit/test_silomanager.py 2014-10-27 13:11:08 +0000
43@@ -20,8 +20,8 @@
44
45
46 class series:
47- name = 'utopic'
48- self_link = 'https://api.launchpad.net/devel/ubuntu/utopic'
49+ name = 'vivid'
50+ self_link = 'https://api.launchpad.net/devel/ubuntu/vivid'
51
52
53 class SiloManagerTestCase(DirectoryAwareTestCase):
54@@ -51,7 +51,7 @@
55 def test_silostate_is_project_unique(self):
56 self.assertFalse(SiloState.is_project_unique(dest, series, 'qtmir'))
57 self.assertTrue(SiloState.is_project_unique(dest, series, 'fubar'))
58- series.self_link = 'not utopic'
59+ series.self_link = 'not vivid'
60 self.assertTrue(SiloState.is_project_unique(dest, series, 'qtmir'))
61
62 @patch('cupstream2distro.silomanager.SiloState.requestid', '1234')
63@@ -69,7 +69,7 @@
64 initMock.return_value = None
65 silo_state = SiloState.find_by_requestid('1234')
66 initMock.assert_called_with('ubuntu-rtm/landing-030')
67- # 30 utopic silos, 30 RTM silos, plus the 2 preprod silos.
68+ # 30 vivid silos, 30 RTM silos, plus the 2 preprod silos.
69 self.assertEqual(initMock.call_count, 62)
70 self.assertIsNone(silo_state)
71
72@@ -352,7 +352,7 @@
73 'ubuntu/landing-123')
74 self.assertEqual(
75 self.state.series,
76- 'https://api.launchpad.net/devel/ubuntu/utopic')
77+ 'https://api.launchpad.net/devel/ubuntu/vivid')
78 self.assertEqual(self.state.state, 3)
79 self.assertEqual(self.state.landers, ['mzanetti', 'greyback', 'kgunn'])
80 self.assertEqual(self.state.requestid, '1411123362781')
81@@ -384,8 +384,8 @@
82 self.assertTrue(self.state._config['source_sync_all_contents'])
83 self.state.source_archive = 'ubuntu'
84 self.assertEqual(self.state._config['source_archive'], 'ubuntu')
85- self.state.source_series = 'utopic'
86- self.assertEqual(self.state._config['source_series'], 'utopic')
87+ self.state.source_series = 'vivid'
88+ self.assertEqual(self.state._config['source_series'], 'vivid')
89 self.state.state = 'snicker'
90 self.state.sources = ['foo', 'bar']
91 self.assertEqual(self.state._config['sources'], ['foo', 'bar'])

Subscribers

People subscribed via source and target branches

to all changes: