Compiz

Merge lp:~timo-jyrinki/compiz/firefox-to-unredirect-exceptions into lp:compiz/0.9.9

  1. firefox-to-unredirect-exceptions
  2. Merge into 0.9.9
Proposed by Timo Jyrinki
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3500
Merged at revision: 3502
Proposed branch: lp:~timo-jyrinki/compiz/firefox-to-unredirect-exceptions
Merge into: lp:compiz/0.9.9
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/composite/composite.xml.in (+1/-1)
To merge this branch: bzr merge lp:~timo-jyrinki/compiz/firefox-to-unredirect-exceptions
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+137807@code.launchpad.net

Commit message

Add Firefox to the unredirect exceptions. (LP: #1086337)

Description of the change

Add Firefox to the unredirect exceptions. (LP: #1086337)

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Are you sure about this? A fullscreen flash video is class Plugin-container.

Or is this for a windowed flash video in a fullscreen Firefox?

review: Needs Information
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

This happens for me with the linked youtube video when clicking the video full screen from the normal youtube view - but I noticed that the confusion is coming from the fact that it's HTML5 video for me, not Flash.

I now also tested that the HTML5 video is shown by default to Ubuntu users (since Adobe Flash is not part of the default installation). Granted most people probably still install Flash, although the percentage is getting slowly lower.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3500
http://jenkins.qa.ubuntu.com/job/compiz-ci/291/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/291/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/291//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/composite/composite.xml.in'
2--- plugins/composite/composite.xml.in 2012-12-03 09:51:54 +0000
3+++ plugins/composite/composite.xml.in 2012-12-04 11:33:33 +0000
4@@ -29,7 +29,7 @@
5 <option name="unredirect_match" type="match">
6 <_short>Unredirect Match</_short>
7 <_long>Specifies which windows will be unredirected when they are fullscreen. You might want to exclude video players for example, to avoid tearing. But this will be at the expense of performance/frame rate. Note: "class=" matching requires the regex plugin to work.</_long>
8- <default>(any) &amp; !(class=Totem) &amp; !(class=MPlayer) &amp; !(class=Vlc) &amp; !(class=Plugin-container)</default>
9+ <default>(any) &amp; !(class=Totem) &amp; !(class=MPlayer) &amp; !(class=Vlc) &amp; !(class=Plugin-container) &amp; !(class=Firefox)</default>
10 </option>
11 <option name="force_independent_output_painting" type="bool">
12 <_short>Force independent output painting.</_short>

Subscribers

People subscribed via source and target branches