Code review comment for lp:~timo-jyrinki/compiz/blacklist_remove_double_escape_from_xml

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

The proposed change results in a build failure (opengl_options.cpp:48:80: error: unknown escape sequence: '\.' [-Werror]), even though if user set it works fine.

Unless other suggestions appear, working on a replacement that removes the escaping altogether from both the xml file and the tests, even though that's of course 'any character' then instead of a dot. There are not many "Mesa 8[anycharacter]0":s other than "Mesa 8.0" in the strings, though.

« Back to merge proposal