Code review comment for lp:~timo-jyrinki/click-update-manager/fix_qt52_use_qpa_platform_minimal

Revision history for this message
dobey (dobey) wrote :

What does setting the platform to "minimal" actually do there? Would not adding "-screen 0 640x480x24" to the xvfb-run args list, be a better fix?

Or if we should use "minimal" for platform, should we not do this in the build system rather than debian/rules, and remove the use of xvfb-run?

Changes like this, we should do always or never; not only in debian/rules.

« Back to merge proposal