Merge lp:~timkuhlman/python-jujuclient/python-jujuclient-packaging-python3 into lp:~tvansteenburgh/python-jujuclient/python-jujuclient-packaging

Proposed by Tim Kuhlman
Status: Merged
Merged at revision: 38
Proposed branch: lp:~timkuhlman/python-jujuclient/python-jujuclient-packaging-python3
Merge into: lp:~tvansteenburgh/python-jujuclient/python-jujuclient-packaging
Diff against target: 37 lines (+11/-2)
2 files modified
debian/control (+9/-1)
debian/rules (+2/-1)
To merge this branch: bzr merge lp:~timkuhlman/python-jujuclient/python-jujuclient-packaging-python3
Reviewer Review Type Date Requested Status
David Britton (community) Approve
Tim Van Steenburgh Pending
Review via email: mp+306943@code.launchpad.net

Description of the change

Build a deb for Python 3 as well as one for Python 2.

Trusty does not have python3-websocket package available. It is however able to use the one from xenial as it is low on dependencies. I expect though that the trusty build will fail.

To post a comment you must log in.
Revision history for this message
David Britton (dpb) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-09-04 17:26:39 +0000
+++ debian/control 2016-09-27 20:22:55 +0000
@@ -2,7 +2,7 @@
2Section: python2Section: python
3Priority: optional3Priority: optional
4Maintainer: Andreas Hasenack <andreas@canonical.com>4Maintainer: Andreas Hasenack <andreas@canonical.com>
5Build-Depends: debhelper (>= 8.0.0), python-all (>= 2.6.6-3~), python-setuptools5Build-Depends: debhelper (>= 8.0.0), python-all (>= 2.6.6-3~), python-setuptools, python3-all, python3-websocket
6Standards-Version: 3.9.46Standards-Version: 3.9.4
7Homepage: https://launchpad.net/python-jujuclient7Homepage: https://launchpad.net/python-jujuclient
88
@@ -12,3 +12,11 @@
12Provides: ${python:Provides}12Provides: ${python:Provides}
13Description: Python API client for juju-core13Description: Python API client for juju-core
14 A simple synchronous python client for the juju-core websocket api.14 A simple synchronous python client for the juju-core websocket api.
15
16Package: python3-jujuclient
17Architecture: all
18Depends: ${misc:Depends}, ${python3:Depends}
19Description: Python API client for Juju (Python 3)
20 A simple synchronous python client for the Juju websocket API.
21 .
22 This package installs the library for Python 3.
1523
=== modified file 'debian/rules'
--- debian/rules 2015-02-25 21:39:08 +0000
+++ debian/rules 2016-09-27 20:22:55 +0000
@@ -8,6 +8,7 @@
88
9# Uncomment this to turn on verbose mode.9# Uncomment this to turn on verbose mode.
10#export DH_VERBOSE=110#export DH_VERBOSE=1
11export PYBUILD_NAME=jujuclient
1112
12%:13%:
13 dh $@ --with python2 --buildsystem=python_distutils14 dh $@ --with python2,python3 --buildsystem=pybuild

Subscribers

People subscribed via source and target branches