Code review comment for lp:~timchen119/gnome-control-center/gnome-control-center.lp1244065

Revision history for this message
Iain Lane (laney) wrote :

Thanks, some comments

 - Please add a changelog entry in debian/changelog (using 'dch')
 - Don't call the patch oem_... (or justify it as an "OEM request" anywhere;
   it's fine that the original request came from there but it should be
   justifiable on its own merits and that should be the reason for us to
   include it in Ubuntu)
 - Please add DEP3 headers: http://dep.debian.net/deps/dep3/

review: Needs Fixing

« Back to merge proposal