Code review comment for lp:~tim-simpson/nova/multiple-notifiers

Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Hmm, you know what, I was thinking about this more last night. I don't think terminating the service is the right thing to do.

The reason being is we don't see the failure until a notification is sent. It's not like a failure on startup, it could happen any any random time in the future.

So, sadly, seems the right thing to do is to log the event, skip the failing import and press on.

review: Needs Fixing

« Back to merge proposal