Code review comment for lp:~tim-simpson/nova/multiple-notifiers

Revision history for this message
Tim Simpson (tim-simpson) wrote :

Hi Matt,

My case is that I want to write all notifications to the log files as well as do something more substantial in response to them. For project Red Dwarf (Database as a Service) we'll be needing to know if the compute manager fails during run_instance in order to free up additional resources that we are provisioning. Since we've forked Nova we could simply hack up the compute manager but would prefer to respond to the notifications to keep our changes easy to separate.

Jason,

I think you're right. My first reaction to the idea of a "fan_out" notifier is I almost can't see why someone would only use one.

However, thinking about it keeping only one "driver" per manager is consistent with the rest of Nova. When the external notifier application is created then only the driver for it will be needed in most situations and having a list will get in the way.

I'll go ahead and update this as you suggested.

Thank you both for the feedback.

« Back to merge proposal