Code review comment for ~till-kamppeter/network-manager:master

Revision history for this message
Iain Lane (laney) wrote :

Thanks for working on this.

I've seen this kind of timeout go wrong when a machine is slow but the test is legitimately proceeding. Then you get a lot of "bump timeout"-style changes and the timeout gets in the way.

Do you know that autopkgtest has various "--timeout" options (notably "--timeout-test"). If you're having problems when iterating to debug the tests failing for another reason, have you considered setting that for yourself instead?

Do you know which operations are hanging and why? Would it be possible to stop that happening?

I'll give you some specific review comments inline.

review: Needs Fixing

« Back to merge proposal