Code review comment for lp:~tigrangab/slingshot/bug_1072036

Revision history for this message
David Gomes (davidgomes) wrote :

>}),

Add a newline after those on the array with the different methods.

Diff lines 48 and 54, remove both.

Also, why not?

foreach (IconLoadFallbackMethod fallback in fallbacks) {
 try {
    fallback.load_icon()
 } catch (Error ) {

 }
}

to avoid some code repetition?

review: Needs Fixing

« Back to merge proposal