Code review comment for lp:~tiagosh/ubuntu/wily/telepathy-qt5/update-0.9.6.1

Revision history for this message
Martin Pitt (pitti) wrote :

The changelog doesn't document/justify the dropping of all patches. I went through them, and most seem to be applied upstream. 02-adapt_to_work_with_q5_final.patch and 05-fix-qt52-build.patch don't seem to be applied at all, but the package builds fine in wily (with Qt 5.4), so I assume they are obsolete.

Please document this in the changelog next time instead of requiring such guesswork.

Uploaded, thanks!

review: Approve

« Back to merge proposal