Code review comment for lp:~tiagosh/telephony-service/request-wake-lock

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

com.canonical.powerd.requestWakeup doesn't acquire a wake lock, it asks for a wakeup signal to be emitted after a timeout. This wakeup signal is special in that it can wake up the phone from suspend, but it doesn't act as a wakelock, i.e. it doesn't inhibit future suspends.

To acquire a wakelock from (re)powerd use instead:

cookie = com.canonical.powerd.requestSysState("telephony-service-indicator", 1)

(where '1' means 'active state')

and to release the wakelock:

com.canonical.powerd.clearSysState(cookie)

review: Needs Fixing

« Back to merge proposal