Code review comment for lp:~tiagosh/telephony-service/flag-mms

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

195 + QString senderId = mMessages[messageId]["senderId"].toString();
196 + QString accountId = mMessages[messageId]["accountId"].toString();
197 + QStringList participantIds = mMessages[messageId]["participantIds"].toStringList();

Instead of looking up for the mMessages[messageId] multiple times, maybe you could cache the result and reuse it instead.

review: Needs Fixing

« Back to merge proposal