Merge lp:~tiagosh/telephony-service/delete_player_instance_on_incoming_call into lp:telephony-service

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1133
Merged at revision: 1144
Proposed branch: lp:~tiagosh/telephony-service/delete_player_instance_on_incoming_call
Merge into: lp:telephony-service
Diff against target: 15 lines (+2/-3)
1 file modified
libtelephonyservice/ringtone.cpp (+2/-3)
To merge this branch: bzr merge lp:~tiagosh/telephony-service/delete_player_instance_on_incoming_call
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+276576@code.launchpad.net

Commit message

Create new QMediaPlayer instances on every incoming call.

Description of the change

Create new QMediaPlayer instances on every incoming call.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libtelephonyservice/ringtone.cpp'
--- libtelephonyservice/ringtone.cpp 2015-05-15 20:27:54 +0000
+++ libtelephonyservice/ringtone.cpp 2015-11-03 17:39:42 +0000
@@ -40,9 +40,8 @@
40 return;40 return;
41 }41 }
4242
43 if (mCallAudioPlayer) {43 // force delete all media player instances
44 return;44 stopIncomingCallSound();
45 }
4645
47 // pick up the new ringtone in case it changed in the meantime46 // pick up the new ringtone in case it changed in the meantime
48 mCallAudioPlaylist.addMedia(QUrl::fromLocalFile(GreeterContacts::instance()->incomingCallSound()));47 mCallAudioPlaylist.addMedia(QUrl::fromLocalFile(GreeterContacts::instance()->incomingCallSound()));

Subscribers

People subscribed via source and target branches