Merge lp:~tiagosh/messaging-app/show_notification_mic_icon into lp:messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 520
Merged at revision: 532
Proposed branch: lp:~tiagosh/messaging-app/show_notification_mic_icon
Merge into: lp:messaging-app
Diff against target: 58 lines (+41/-0)
1 file modified
src/qml/ComposeBar.qml (+41/-0)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/show_notification_mic_icon
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+287212@code.launchpad.net

Commit message

Show notification when the the record icon is only clicked.

Description of the change

Show notification when the the record icon is only clicked.

To post a comment you must log in.
517. By Tiago Salem Herrmann

Show notification when the the record icon is only clicked

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
518. By Tiago Salem Herrmann

Use popover instead of notification

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
519. By Tiago Salem Herrmann

Avoid dismissing the osk

520. By Tiago Salem Herrmann

Close popup when text changes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Can you make the background of the popup dark? (maybe follow the translucent black scheme used by the notifications?)?
The contrast between the hint and the rest of the content on screen is really bad, which makes it hard to notice.

review: Needs Fixing
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve
521. By Tiago Salem Herrmann

Fix osk focus on new message screen

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/ComposeBar.qml'
--- src/qml/ComposeBar.qml 2016-03-07 21:16:20 +0000
+++ src/qml/ComposeBar.qml 2016-03-17 18:41:13 +0000
@@ -138,6 +138,32 @@
138 }138 }
139 }139 }
140140
141 Component {
142 id: microphoneWarningPopover
143
144 Popover {
145 id: popover
146 Column {
147 id: containerLayout
148 anchors {
149 left: parent.left
150 top: parent.top
151 right: parent.right
152 }
153 ListItem.Standard {
154 text: i18n.tr("You have to press and hold the record icon")
155 onClicked: {
156 PopupUtils.close(popover)
157 }
158 }
159 Connections {
160 target: composeBar
161 onTextChanged: PopupUtils.close(popover)
162 }
163 }
164 }
165 }
166
141 ListItem.ThinDivider {167 ListItem.ThinDivider {
142 anchors.top: parent.top168 anchors.top: parent.top
143 }169 }
@@ -551,6 +577,21 @@
551 iconColor: composeBar.recording ? "black" : "gray"577 iconColor: composeBar.recording ? "black" : "gray"
552 iconName: "audio-input-microphone-symbolic"578 iconName: "audio-input-microphone-symbolic"
553579
580 onClicked: {
581 if (!composeBar.audioAttached) {
582 var oskFocus = null
583 if (textEntry.activeFocus) {
584 oskFocus = composeBar.forceFocus
585 } else if (multiRecipient.activeFocus) {
586 oskFocus = multiRecipient.forceActiveFocus
587 }
588 PopupUtils.open(microphoneWarningPopover, recordButton)
589 // avoid dismissing the osk
590 if (oskFocus) {
591 oskFocus()
592 }
593 }
594 }
554 onPressed: audioRecordingBar.startRecording()595 onPressed: audioRecordingBar.startRecording()
555 onReleased: {596 onReleased: {
556 audioRecordingBar.stopRecording()597 audioRecordingBar.stopRecording()

Subscribers

People subscribed via source and target branches