Merge lp:~tiagosh/messaging-app/fix-highlight_current_item into lp:messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 71
Merged at revision: 74
Proposed branch: lp:~tiagosh/messaging-app/fix-highlight_current_item
Merge into: lp:messaging-app
Diff against target: 40 lines (+9/-0)
1 file modified
src/qml/Messages.qml (+9/-0)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/fix-highlight_current_item
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+208871@code.launchpad.net

Commit message

set highlightFollowsCurrentItem to false to avoid unexpected behaviors with qt5.2

Description of the change

set highlightFollowsCurrentItem to false to avoid unexpected behaviors with qt5.2

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
71. By Tiago Salem Herrmann

scroll view when sending a new message.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved. works as expected under qt5.2 and has no effect on Qt5.0

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/Messages.qml'
--- src/qml/Messages.qml 2014-02-18 21:12:44 +0000
+++ src/qml/Messages.qml 2014-02-28 22:13:35 +0000
@@ -38,6 +38,7 @@
38 // FIXME: MainView should provide if the view is in portait or landscape38 // FIXME: MainView should provide if the view is in portait or landscape
39 property int orientationAngle: Screen.angleBetween(Screen.primaryOrientation, Screen.orientation)39 property int orientationAngle: Screen.angleBetween(Screen.primaryOrientation, Screen.orientation)
40 property bool landscape: orientationAngle == 90 || orientationAngle == 27040 property bool landscape: orientationAngle == 90 || orientationAngle == 270
41 property bool pendingMessage: false
41 flickable: null42 flickable: null
42 title: {43 title: {
43 if (landscape) {44 if (landscape) {
@@ -392,6 +393,7 @@
392 listModel: threadId !== "" ? sortProxy : null393 listModel: threadId !== "" ? sortProxy : null
393 verticalLayoutDirection: ListView.BottomToTop394 verticalLayoutDirection: ListView.BottomToTop
394 spacing: units.gu(2)395 spacing: units.gu(2)
396 highlightFollowsCurrentItem: false
395 listDelegate: MessageDelegate {397 listDelegate: MessageDelegate {
396 id: messageDelegate398 id: messageDelegate
397 incoming: senderId != "self"399 incoming: senderId != "self"
@@ -428,6 +430,12 @@
428 eventModel.removeEvent(event.accountId, event.threadId, event.eventId, event.type)430 eventModel.removeEvent(event.accountId, event.threadId, event.eventId, event.type)
429 }431 }
430 }432 }
433 onCountChanged: {
434 if (messages.pendingMessage) {
435 messageList.contentY = 0
436 messages.pendingMessage = false
437 }
438 }
431 }439 }
432440
433 Item {441 Item {
@@ -501,6 +509,7 @@
501 HistoryThreadModel.MatchPhoneNumber,509 HistoryThreadModel.MatchPhoneNumber,
502 true)510 true)
503 }511 }
512 messages.pendingMessage = true
504 chatManager.sendMessage(participants, textEntry.text)513 chatManager.sendMessage(participants, textEntry.text)
505 textEntry.text = ""514 textEntry.text = ""
506 }515 }

Subscribers

People subscribed via source and target branches