Merge lp:~tiagosh/messaging-app/fix-broken-test into lp:messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 159
Merged at revision: 158
Proposed branch: lp:~tiagosh/messaging-app/fix-broken-test
Merge into: lp:messaging-app
Diff against target: 29 lines (+3/-2)
2 files modified
src/qml/Messages.qml (+1/-0)
tests/autopilot/messaging_app/emulators.py (+2/-2)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/fix-broken-test
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Brendan Donegan (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+227949@code.launchpad.net

Commit message

fix broken test

Description of the change

fix broken test

To post a comment you must log in.
158. By Tiago Salem Herrmann

use objectName instead of icon name

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Looks good, thanks

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Actually if you have the chance to quickly change the docstring from:

"""Return toolbar icon with name contact"""

to

"""Return toolbar icon to add contact"""

then please do so. I won't insist on it though.

159. By Tiago Salem Herrmann

change comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/Messages.qml'
--- src/qml/Messages.qml 2014-07-18 14:08:05 +0000
+++ src/qml/Messages.qml 2014-07-24 13:22:26 +0000
@@ -324,6 +324,7 @@
324 }324 }
325 Icon {325 Icon {
326 id: addIcon326 id: addIcon
327 objectName: "addNewRecipientIcon"
327 visible: multiRecipient.visible328 visible: multiRecipient.visible
328 height: units.gu(3)329 height: units.gu(3)
329 width: units.gu(3)330 width: units.gu(3)
330331
=== modified file 'tests/autopilot/messaging_app/emulators.py'
--- tests/autopilot/messaging_app/emulators.py 2014-07-17 16:09:02 +0000
+++ tests/autopilot/messaging_app/emulators.py 2014-07-24 13:22:26 +0000
@@ -146,11 +146,11 @@
146 )146 )
147147
148 def get_toolbar_add_contact_icon(self):148 def get_toolbar_add_contact_icon(self):
149 """Return toolbar icon with name new-contact"""149 """Return toolbar icon to add contact"""
150150
151 return self.select_single(151 return self.select_single(
152 'Icon',152 'Icon',
153 name='new-contact',153 objectName='addNewRecipientIcon',
154 )154 )
155155
156 def click_add_contact_icon(self):156 def click_add_contact_icon(self):

Subscribers

People subscribed via source and target branches