Merge lp:~tiagosh/messaging-app/fix-1231442 into lp:messaging-app
Proposed by
Tiago Salem Herrmann
Status: | Merged |
---|---|
Approved by: | Gustavo Pichorim Boiko |
Approved revision: | 41 |
Merged at revision: | 40 |
Proposed branch: | lp:~tiagosh/messaging-app/fix-1231442 |
Merge into: | lp:messaging-app |
Diff against target: |
145 lines (+65/-31) 2 files modified
src/qml/Messages.qml (+60/-5) src/qml/ThreadDelegate.qml (+5/-26) |
To merge this branch: | bzr merge lp:~tiagosh/messaging-app/fix-1231442 |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Gustavo Pichorim Boiko (community) | Approve | ||
Review via email: mp+188088@code.launchpad.net |
Commit message
Replace the "new contact" icon used for unknown contacts on the conversations list by the default avatar.
Remove popup when tapping unknown contact avatars and implement a dialog for adding new contacts.
Description of the change
Replace the "new contact" icon used for unknown contacts on the conversations list by the default avatar.
Remove popup when tapping unknown contact avatars and implement a dialog for adding new contacts.
To post a comment you must log in.
PASSED: Continuous integration, rev:40 jenkins. qa.ubuntu. com/job/ messaging- app-ci/ 59/ jenkins. qa.ubuntu. com/job/ generic- mediumtests- saucy/4126 jenkins. qa.ubuntu. com/job/ generic- mediumtests- touch/1768 jenkins. qa.ubuntu. com/job/ messaging- app-saucy- amd64-ci/ 59 jenkins. qa.ubuntu. com/job/ messaging- app-saucy- armhf-ci/ 59 jenkins. qa.ubuntu. com/job/ messaging- app-saucy- armhf-ci/ 59/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ messaging- app-saucy- i386-ci/ 59 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-saucy/ 427 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-i386/ 4251 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-i386/ 4251/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 1770 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 1770/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- maguro/ 1473 jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- mako/1485
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ messaging- app-ci/ 59/rebuild
http://