Merge lp:~tiagosh/dialer-app/fix-1398525 into lp:dialer-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 324
Merged at revision: 324
Proposed branch: lp:~tiagosh/dialer-app/fix-1398525
Merge into: lp:dialer-app
Diff against target: 34 lines (+8/-2)
1 file modified
src/qml/LiveCallPage/LiveCall.qml (+8/-2)
To merge this branch: bzr merge lp:~tiagosh/dialer-app/fix-1398525
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
Review via email: mp+243675@code.launchpad.net

Commit message

Consider "wired_headset" and "earpiece" as default audio outputs.

Description of the change

Consider "wired_headset" and "earpiece" as default audio outputs.

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~tiagosh/telepathy-ofono/fix-1398525/+merge/243676

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/LiveCallPage/LiveCall.qml'
--- src/qml/LiveCallPage/LiveCall.qml 2014-11-13 14:40:57 +0000
+++ src/qml/LiveCallPage/LiveCall.qml 2014-12-04 14:34:12 +0000
@@ -87,6 +87,12 @@
87 closeTimer.running = true;87 closeTimer.running = true;
88 }88 }
8989
90 function isDefaultAudioOutput(id) {
91 return (id == "default" ||
92 id == "wired_headset" ||
93 id == "earpiece")
94 }
95
90 Connections {96 Connections {
91 target: callManager97 target: callManager
92 onHasCallsChanged: {98 onHasCallsChanged: {
@@ -544,7 +550,7 @@
544 }550 }
545 }551 }
546 }552 }
547 selected: activeAudioOutput != "default"553 selected: !isDefaultAudioOutput(activeAudioOutput)
548 iconWidth: units.gu(3)554 iconWidth: units.gu(3)
549 iconHeight: units.gu(3)555 iconHeight: units.gu(3)
550 onClicked: {556 onClicked: {
@@ -557,7 +563,7 @@
557 PopupUtils.open(audioOutputsPopover, speakerButton)563 PopupUtils.open(audioOutputsPopover, speakerButton)
558 return564 return
559 }565 }
560 if (call.activeAudioOutput == "default") {566 if (isDefaultAudioOutput(call.activeAudioOutput)) {
561 call.activeAudioOutput = "speaker"567 call.activeAudioOutput = "speaker"
562 } else {568 } else {
563 call.activeAudioOutput = "default"569 call.activeAudioOutput = "default"

Subscribers

People subscribed via source and target branches