Merge lp:~thumper/unity/hacking into lp:unity

Proposed by Tim Penhey
Status: Merged
Merged at revision: 1635
Proposed branch: lp:~thumper/unity/hacking
Merge into: lp:unity
Diff against target: 22 lines (+2/-3)
1 file modified
plugins/unityshell/src/unityshell.cpp (+2/-3)
To merge this branch: bzr merge lp:~thumper/unity/hacking
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Review via email: mp+77260@code.launchpad.net

Description of the change

CCSM was deleting and recreating the UnityScreen.

In the past, I had commented out the delete wt (windows thread) in the UnityScreen destructor because it was crashing on exit. This was causing CCSM to initiate a crash in unity as nux doesn't like having multiple threads.

I've fixed the nux dependencies in https://code.launchpad.net/~thumper/nux/view-deletion-after-window-thread/+merge/77256.

Also noticed that the switcher controller wasn't being deleted.

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/unityshell/src/unityshell.cpp'
--- plugins/unityshell/src/unityshell.cpp 2011-09-27 16:12:35 +0000
+++ plugins/unityshell/src/unityshell.cpp 2011-09-28 01:49:27 +0000
@@ -315,6 +315,7 @@
315 switcher_desktop_icon->UnReference();315 switcher_desktop_icon->UnReference();
316 panelController->UnReference();316 panelController->UnReference();
317 delete controller;317 delete controller;
318 delete switcherController;
318 launcherWindow->UnReference();319 launcherWindow->UnReference();
319320
320 notify_uninit();321 notify_uninit();
@@ -334,9 +335,7 @@
334 ::unity::ui::IconRenderer::DestroyTextures();335 ::unity::ui::IconRenderer::DestroyTextures();
335 QuicklistManager::Destroy();336 QuicklistManager::Destroy();
336337
337 // Deleting the windows thread calls XCloseDisplay, which calls XSync, which338 delete wt;
338 // sits waiting for a reply.
339 // delete wt;
340}339}
341340
342void UnityScreen::initAltTabNextWindow()341void UnityScreen::initAltTabNextWindow()