Code review comment for lp:~thumper/launchpad/recipe-new-ppa

Hi Tim,
great idea to fix this! I just wish we had a nice "combo box" widget that would allow selection or creation. I don't know if the picker widget (branch/person) could be used for that, too. But your solution is nice, too.

I have one major complaint, though: It does not work. When I select "Create new PPA for this recipe" and submit the form, I get an error "Required input is missing." under the drop-down box and if I left the text field empty it complains that "You already have a PPA named 'ppa'." The latter is actually true but confusing because the text field is empty.

It is true that person/+activate-ppa defaults to "ppa" but it actually preloads the input field with that string but only if this is the first ppa being created. Otherwise there is no default. This is what should happen here, too.

Sorry but this cannot yet be landed without these issues being resolved.

Cheers, Henning