Code review comment for lp:~thumper/launchpad/recipe-inline-edit-recipe-text

Revision history for this message
Leonard Richardson (leonardr) wrote :

I don't understand why you got rid of the CSS styles for edit-description and edit-commit-message. Did you already generalize those widgets, and you're just cleaning up the CSS?

Your annotations create a situation where setRecipeText is published in version 1.0 of the web service but absent in version devel, and in which you can PATCH ISourcePackageRecipe['recipe_text'] in devel but not in 1.0. I'd like to see some tests of that using launchpadlib. Your windmill test only tests that you can PATCH ISourcePackageRecipe['recipe_test'] in devel.

I don't think this is that big a deal, but if you care enough to distinguish between 1.0 and devel in the first place, you should test the different versions. Let me know if you need help with the tests. I'll start you out by saying that you can us launchpadlib_for("test", person, version="1.0") to get a launchpadlib that operates against 1.0.

review: Needs Fixing

« Back to merge proposal