Merge lp:~thumper/launchpad/moar-request-build-logging into lp:launchpad

Proposed by Tim Penhey
Status: Merged
Approved by: Graham Binns
Approved revision: no longer in the source branch.
Merged at revision: 12187
Proposed branch: lp:~thumper/launchpad/moar-request-build-logging
Merge into: lp:launchpad
Diff against target: 60 lines (+12/-5)
2 files modified
lib/lp/code/model/sourcepackagerecipebuild.py (+10/-4)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+2/-1)
To merge this branch: bzr merge lp:~thumper/launchpad/moar-request-build-logging
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Review via email: mp+45803@code.launchpad.net

Commit message

[r=gmb][ui=none][no-qa] Adds more logging to the request_daily_build script.

Description of the change

Adds more logging to the request_daily_build script.

This would have been really useful in some debugging I was just doing.

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/code/model/sourcepackagerecipebuild.py'
--- lib/lp/code/model/sourcepackagerecipebuild.py 2010-12-20 20:36:16 +0000
+++ lib/lp/code/model/sourcepackagerecipebuild.py 2011-01-11 01:11:59 +0000
@@ -11,6 +11,7 @@
11 ]11 ]
1212
13import datetime13import datetime
14import logging
14import sys15import sys
1516
16from psycopg2 import ProgrammingError17from psycopg2 import ProgrammingError
@@ -185,25 +186,30 @@
185 def makeDailyBuilds(logger=None):186 def makeDailyBuilds(logger=None):
186 from lp.code.model.sourcepackagerecipe import SourcePackageRecipe187 from lp.code.model.sourcepackagerecipe import SourcePackageRecipe
187 recipes = SourcePackageRecipe.findStaleDailyBuilds()188 recipes = SourcePackageRecipe.findStaleDailyBuilds()
189 if logger is None:
190 logger = logging.getLogger()
188 builds = []191 builds = []
189 for recipe in recipes:192 for recipe in recipes:
193 logger.debug(
194 'Recipe %s/%s is stale', recipe.owner.name, recipe.name)
190 for distroseries in recipe.distroseries:195 for distroseries in recipe.distroseries:
196 series_name = distroseries.named_version
191 try:197 try:
192 build = recipe.requestBuild(198 build = recipe.requestBuild(
193 recipe.daily_build_archive, recipe.owner,199 recipe.daily_build_archive, recipe.owner,
194 distroseries, PackagePublishingPocket.RELEASE)200 distroseries, PackagePublishingPocket.RELEASE)
195 except BuildAlreadyPending:201 except BuildAlreadyPending:
202 logger.debug(
203 ' - build already pending for %s', series_name)
196 continue204 continue
197 except ProgrammingError:205 except ProgrammingError:
198 raise206 raise
199 except:207 except:
208 logger.exception(' - problem with %s', series_name)
200 info = sys.exc_info()209 info = sys.exc_info()
201 errorlog.globalErrorUtility.raising(info)210 errorlog.globalErrorUtility.raising(info)
202 else:211 else:
203 if logger is not None:212 logger.debug(' - build requested for %s', series_name)
204 logger.debug(
205 'Build for %s/%s requested',
206 recipe.owner.name, recipe.name)
207 builds.append(build)213 builds.append(build)
208 recipe.is_stale = False214 recipe.is_stale = False
209 return builds215 return builds
210216
=== modified file 'lib/lp/code/model/tests/test_sourcepackagerecipebuild.py'
--- lib/lp/code/model/tests/test_sourcepackagerecipebuild.py 2010-12-23 00:38:29 +0000
+++ lib/lp/code/model/tests/test_sourcepackagerecipebuild.py 2011-01-11 01:11:59 +0000
@@ -251,7 +251,8 @@
251 logger = BufferLogger()251 logger = BufferLogger()
252 SourcePackageRecipeBuild.makeDailyBuilds(logger)252 SourcePackageRecipeBuild.makeDailyBuilds(logger)
253 self.assertEqual(253 self.assertEqual(
254 'DEBUG Build for eric/funky-recipe requested\n',254 'DEBUG Recipe eric/funky-recipe is stale\n'
255 'DEBUG - build requested for Warty (4.10)\n',
255 logger.getLogBuffer())256 logger.getLogBuffer())
256257
257 def test_makeDailyBuilds_clears_is_stale(self):258 def test_makeDailyBuilds_clears_is_stale(self):