Code review comment for lp:~thumper/launchpad/makefile-fix

On Tue, 07 Dec 2010 12:07:37 you wrote:
> On 12/06/2010 05:56 PM, Tim Penhey wrote:
> > On Tue, 07 Dec 2010 11:16:07 you wrote:
> >> The proposal to merge lp:~thumper/launchpad/makefile-fix into
> >> lp:launchpad has been updated.
> >>
> >> Commit Message changed to:
> >>
> >> [release-critical=abentley][r=henninge][ui=none][bug=683503]
> >
> > Well that was stupid. lp-land offered me the ability to edit the commit
> > message, which I did, but obviously it set the commit message over the
> > api before it got my edit.
>
> Is your bzr_editor configured properly? It should be a program that
> does not fork into the background, only returning control when the file
> has been edited. e.g. to use gvim, I specify "gvim -f"

Well the script waited and submitted it correctly (afaik).

Tim