Code review comment for lp:~thumper/launchpad/makefile-fix

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/06/2010 05:56 PM, Tim Penhey wrote:
> On Tue, 07 Dec 2010 11:16:07 you wrote:
>> The proposal to merge lp:~thumper/launchpad/makefile-fix into lp:launchpad
>> has been updated.
>>
>> Commit Message changed to:
>>
>> [release-critical=abentley][r=henninge][ui=none][bug=683503]
>
> Well that was stupid. lp-land offered me the ability to edit the commit
> message, which I did, but obviously it set the commit message over the api
> before it got my edit.

Is your bzr_editor configured properly? It should be a program that
does not fork into the background, only returning control when the file
has been edited. e.g. to use gvim, I specify "gvim -f"

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkz9a9MACgkQ0F+nu1YWqI0oMgCeKF2kJ4RdUcRDVRAU4ezmIz57
Uy8An0aHsPbCT/kC/jZuk+jiJswS5cSe
=icEm
-----END PGP SIGNATURE-----

« Back to merge proposal