Merge lp:~thumper/launchpad/fix-mailman-excessive-queries into lp:launchpad
Proposed by
Tim Penhey
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11803 |
Proposed branch: | lp:~thumper/launchpad/fix-mailman-excessive-queries |
Merge into: | lp:launchpad |
Diff against target: |
127 lines (+49/-16) 5 files modified
lib/lp/registry/doc/message-holds.txt (+4/-4) lib/lp/registry/interfaces/mailinglist.py (+11/-0) lib/lp/registry/model/mailinglist.py (+29/-1) lib/lp/registry/tests/mailinglists_helper.py (+1/-6) lib/lp/registry/xmlrpc/mailinglist.py (+4/-5) |
To merge this branch: | bzr merge lp:~thumper/launchpad/fix-mailman-excessive-queries |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+39335@code.launchpad.net |
Commit message
Make getMessageDispo
Description of the change
The current implementation of getMessageDispo
This causes OOPSes like OOPS-1758XMLP341.
I changed the implementation of the IMessageApprovalSet to do the joins and return just the message_id and team names as needed. I also implemented a new method that does a set based update.
tests:
message-holds
mailinglists
To post a comment you must log in.
Really nice branch Tim.
I think you have a typo in your new method name that got propagated. agesWithStats -> agesWithStatus
acknowledgeMess
acknowledgeMess