Code review comment for lp:~thumper/launchpad/edit-commit-msg-link

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

All the interesting stuff is Javascript, which I don't really feel competent to review :( It looks fine, but I don't know anything about our coding standards really.

I'm not sure that the block starting:

+ <div id="commit-message" class="yui-g">
+ <tal:no-commit-message condition="not: context/commit_message">

Can't be better factored, but it's TAL so maybe not.

review: Abstain

« Back to merge proposal