Code review comment for lp:~thumper/launchpad/daily-ajax

Revision history for this message
Tim Penhey (thumper) wrote :

On Sat, 12 Feb 2011 07:55:32 you wrote:
> Here's a patch that fixes this up some. It:
>
> * ensures there is a spinner during the XHR work
> * avoids sleep during the test
> * avoids xpath
> * always use a timeout on waits.forElement
> * doesn't rely on a page reload to confirm data

Thanks for this Deryck. I've included your patch. We need to make sure that
more Javascript reviewers understand the best way to write the windmill tests.

« Back to merge proposal