Code review comment for lp:~thumper/launchpad/daily-ajax
Revision history for this message
| Tim Penhey (thumper) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Fri, 11 Feb 2011 19:17:53 you wrote:
> Review: Approve
> @wgrant, @thumper - Theres an odd structure here:
>
> The mixin looks like it could just depend on the Editablewidgetbase
> protocol; I wouldn't use a mixin at this point, just pull it up to the
> base class (and pull the self.tag setting up too).
>
> Have a think about this, but don't feel you need to tell me what you choose
> to do.
I did think about this, but the multiline editor does not need it, so I
decided not to put it into the EditableWidgetBase.