Code review comment for lp:~thumper/launchpad/daily-ajax
Revision history for this message
| Deryck Hodge (deryck) wrote | # |
review:
Needs Fixing
(javascript code)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi, all.
There are some problems with this widget and Windmill test. The widget doesn't show a spinner while it's doing XHR work, and the Windmill test shouldn't be using sleep or xpath for this simple of a test. I'm having a poke at this branch briefly to see if I can just provide a diff to show how this should work (in the hopes that that is helpful and not intrusive ;)) and will reply back when I come up with something.
Cheers,
deryck