Code review comment for lp:~thumper/launchpad/daily-ajax

Revision history for this message
William Grant (wgrant) wrote :

This looks good. Just a few comments:

 - In style-3-0.css.in, there is a space missing after "cursor:".
 - In the help page: "before the 24 period is up" needs a s/24 period/24 hour period/. It also seems slightly repetitive, but it may be needed for clarity.
 - You've changed "Built daily" to "Build daily". Was that deliberate? I slightly prefer the former, but am not really fussed.
 - This UI is very different from the "Automatically build each day, if the source has changed" checkbox when creating a new recipe. Can we use the same option buttons and help there too?

review: Approve (code*)

« Back to merge proposal